IQSS/10883-License Enhancements #11232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
changed the title
ghost
approved these changes
Feb 13, 2025
scolapasta
moved this from SPRINT READY
to This Sprint 🏃♀️ 🏃
in IQSS Dataverse Project
scolapasta
moved this from This Sprint 🏃♀️ 🏃
to Ready for Review ⏩
in IQSS Dataverse Project
sekmiller
approved these changes
Feb 27, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
No issues found with this PR. Merging |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Member
|
@ofahimIQSS @qqmyers @jeromeroucou now that this PR has been merged does the JSON French license in this PR need to be revisited? Would it still work? |
Member
Author
|
Things should be null safe, so the new fields aren't needed. |
Contributor
I agree with @qqmyers But if you are OK, I will push an update with new fields as soon as I have confirmation of which |
Member
|
@jeromeroucou sure, sounds good. Please do create a PR when you're ready. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Multiple license changes per #10883, affecting attributes that can be uploaded for new licenses and what is sent to DataCite.
Which issue(s) this PR closes:
Special notes for your reviewer: This should cover all the points listed in the issue, plus the optional add of a language parameter.
Suggestions on how to test this: ~Regression testing - licenses should work as before on a new db as well as after an update of an existing db. The new feature is primarily in what gets sent to DataCite, so creating a dataset, selecting a license, publishing, and then verifying that the DataCite export has the new rights attributes and xml:lang entry as shown in the issue should do it.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included.
Additional documentation: