ORCID: Support authenticated ORCIDs in account profile #11222
Conversation
qqmyers
added
Size: 10
|
Great! Is this only for Dataverse internal accounts? |
|
No - it doesn't matter how you log in. |
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Tests are failing as of https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11222/8/testReport/ but I'm pretty sure these are test that are known to be failing:
Thank you, @qqmyers for addressing all my concerns. I pushed a couple doc tweaks while I was on the branch.
I didn't test the feature at all but the code makes sense to me, and it's a very nice feature! Approved.
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
|
Getting error on this: Caused by: org.flywaydb.core.api.exception.FlywayValidateException: Validate failed: Migrations have failed validation |
|
This PR needs to get updated, seeing branch conflicts - Thanks! |
|
Testing Evidence: -bash-4.2$ 'psql -U dvnapp -d dvndbsimple -c "UPDATE authenticationproviderrow set enabled='t' where id='orcid-public'"'
-bash-4.2$ psql -U dvnapp -d dvndbsimple -c "UPDATE authenticationproviderrow set enabled='f' where id='orcid-public'"
|
|
Branch has conflicts One observation was made which we are currently investigating: |
|
I see continuous-integration failing on this one |
|
Everything looks good on this PR - waiting for continuous-integration to pass, and then I will merge. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
6 participants
What this PR does / why we need it: This PR adds one area of functionality supported through a grant to GDCC from the ORCID Global Participation Fund.
Specifically, it allows Dataverse users to add a link to their ORCID profile which then allows Dataverse to use automatically add their ORCID to their author metadata when they create a dataset.
This functionality leverages Dataverse's existing support for login via ORCID, but can be turned on independently of it. If ORCID login is enabled, the user's ORCID will automatically be added to their profile. If the user has logged in via some other mechanism, they are able to click a button to initiate a similar authentication process in which the user must login to their ORCID account and approve the connection.
This PR should be functional as is, but it is possible/likely that further changes could be made based on user feedback.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Use/create an ORCID OAuth2 provider as was previously possible and verify that logging in with that provider adds the ORCID to the user account (Account Info page), that when logging in with a builtin/other account, you can click the 'Add Authenticated ORCID' button to add one, and use the Edit Account/Remove ORCID menu item to remove it, that while the ORCID is in the account from whatever route, that creating a dataset results in the user with their ORCID being added as an author of the dataset.
To verify that this new functionality can be configured w/o allowing ORCID login, reinstall the ORCID provider with its "enabled" flag set false (or toggle the enabled field in the db, e.g.
update authenticationproviderrow set enabled='f' where id='orcid';for a standard config.)Also verify that if no ORCID provider exists, the ability to add an ORCID is not displayed.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Account Info showing option to add ORCID
ORCID login
ORCID Approval screen
ORCID in Account Info pane showing remove orcid menu item
New Dataset showing ORCID of author used when auto-filling.
Is there a release notes update needed for this change?: included
Additional documentation:
Preview docs at https://dataverse-guide--11222.org.readthedocs.build/en/11222/installation/orcid.html