Improvements on PR #10198 #11019
Merged
Improvements on PR #10198 #11019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
reviewed
Nov 19, 2024
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
All tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11019/2/testReport/
I see an extra colon that's bothering me. Will fix.
pdurbin
approved these changes
Nov 19, 2024
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
In d77ff0d I cleaned up the docs a bit. Approved.
Thanks for the PR, @jeromeroucou!
Contributor
Author
|
Thanks for your review @pdurbin ! |
cmbz
added
FY25 Sprint 10
Contributor
|
Ran SavedSearchIT.java in local - test ran successfully. Merging PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Complete improvements suggested by @pdurbin on closed PR #10198
Which issue(s) this PR closes:
Special notes for your reviewer:
I completed the TODO by moving some parts of the test source code from
SavedSearchITtoUtilIT. And please review the issue #10893 before read the code.Suggestions on how to test this:
The
SavedSearchIT.javaclass has some integration tests that can be run using a local development environment (docker).The modifications on documentation can be preview on https://dataverse-guide--11019.org.readthedocs.build/en/11019/api/native-api.html#saved-search
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
No