Minor Bug sending software name/version to DataCite #10919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
approved these changes
Oct 15, 2024
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't test this but the fix make sense to me. Approved.
cmbz
added
FY25 Sprint 8
Contributor
|
Tested and no issues were found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Per the plan https://docs.google.com/document/d/1JzDo9UOIy9dVvaHvtIbOI8tFU6bWdfDfuQvWWpC0tkA/edit?usp=sharing,
the DataCite XML updates done in v6.4 were supposed to send the software name when no software version was supplied and the name, version when the version is supplied. The code does not do that and would append a blank/null version in the no version case due to a misplaced parenthesis.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Create a dataset with a software name and no version, publish it and check the DataCite export. You'll see a line like
<description descriptionType="TechnicalInfo">DVUploader, null</description>before and
<description descriptionType="TechnicalInfo">DVUploader</description>after it.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: