Fix "Update Current Version" to prevent metadata loss #10797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could allow PID update to be fatal again when provider service is down (not tested so left as is)
landreev
reviewed
Aug 26, 2024
.../java/edu/harvard/iq/dataverse/engine/command/impl/CuratePublishedDatasetVersionCommand.java
Outdated
Show resolved
Hide resolved
landreev
approved these changes
Aug 26, 2024
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
Special thanks for adding an extended test.
pdurbin
changed the title
pdurbin
changed the title
ghost
pushed a commit
to DataverseNO/dataverse
that referenced
this pull request
Sep 12, 2024
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR extends #10786, removing use of other commands within this one to avoid the possibility of partial updates (as was seen prior to both PRs when DataCite was down or when terms (and not metadata) were changed.
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer: Have yet to see the updated IT test run (here or in #10786)
FWIW: In removing the em.merges after adding the initial merge of the dataset, I used the em.contains() test to verify that the initial merge of the dataset also merged the versions, etc. - not sure I was aware of that call before this, but I think it might be useful in deciding if merges are really needed (as it looks like merging a version gets expensive with many files).
Suggestions on how to test this:
Update a terms field (e.g. terms of use (with no license/custom terms), save, and then, as superuser hit the publish/update-current-version option. It should work now.
Similarly, I think you can misconfigure DataCite to simulate a failure of their service, try any update and publish/update-current-version. The command should succeed and there should be a warning line in the log.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: