Skip to content

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Jun 25, 2024

What this PR does / why we need it: Performance testing and subsequent investigation shows that using the commit_within parameter in the solrj calls was disabling the autoSoftCommit by maxTime set at 1 second in the solrconfig.xml, causing delays in newly indexed things being visible of up to 30 seconds. (It's not clear if this is new with the new solr version or not - there was some discussion in #10559 about latency, but nothing near the ~30 seconds we're seeing now.) Removing them appears to re-enable the autoSoftCommit. (FWIW: the commit_within parameter did not disable using autoSoftCommit with maxDocs instead.)

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this: Doing a full reindex on a db that should take 30 seconds + and repeatedly checking to see when counts show in the interface is how this was detected. You should see changes every ~1 second/as fast as you can refresh. Nominally any other call to index should cause new results to appear within a few seconds (however long indexing takes plus the 1 second autoSoftCommit) and nothing near 30 seconds (which is our default autoCommit (hard) setting.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers added this to the 6.3 milestone Jun 25, 2024
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Jun 25, 2024
@stevenwinship stevenwinship self-assigned this Jun 25, 2024
@stevenwinship stevenwinship removed their assignment Jun 25, 2024
@landreev landreev self-assigned this Jun 26, 2024
@landreev landreev merged commit 94b15e2 into IQSS:develop Jun 26, 2024
@landreev landreev removed their assignment Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: 3 A percentage of a sprint. 2.1 hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants