IQSS/10557-fix-installer-pid-setup #10563
Conversation
|
@qqmyers thanks for the PR! As I was saying at standup and in Slack just now, we have reason to believe that people installing Dataverse 6.2 for the first time (non-upgrade) using traditional methods (non-Docker) will be unable to create datasets (Issue#10557). Thank you, Jim, for providing a fix in PR#10563. Assuming this is right, we should rebundle dvinstall.zip with the fixed script, indicate this at the top of the release notes, and send a message to the google group |
|
As I explained at #10557 (comment) I can easily reproduce the bug. Accept all the installer defaults and you can't create a dataset. I haven't tested the changes to the Java code in this PR but as mentioned on Slack I did test the new as-setup.sh script and it fixes the problem. I can create a dataset. I went ahead and uploaded a new dvinstall.zip to the release with the new script (I replaced it in place with
Please feel free to edit further. Oh, I renamed the old dvinstall.zip to sus.zip. We can probably delete it. |
|
The PR looks good, the installer works; I was ready to merge, but noticed that Jenkins tests never ran on it. I don't think it's necessary, but figured I'd run it just in case, to make sure the config check works with the Jenkins environment. |
5 participants
What this PR does / why we need it: This PR adds a missing command to set the default pid provider in the as-setup.sh file. It also adds a check in the ConfigChecker service to make sure one is set.
Which issue(s) this PR closes:
Closes #10557
Special notes for your reviewer:
Suggestions on how to test this: Run this installer (vs docker setup). Could also verify that after the PR, removing the default-provider setting causes starting payara to fail at the config checker stage with a warning in the log.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: