Allow optional Croissant exporter to replace JSON-LD <head> content #10382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-tosca
added
Feature: Metadata
Size: 10
This comment has been minimized.
This comment has been minimized.
jp-tosca
changed the title
pdurbin
changed the title
pdurbin
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jp-tosca
changed the title
Contributor
Author
|
@pdurbin done 🚀 |
This comment has been minimized.
This comment has been minimized.
pdurbin
reviewed
Mar 20, 2024
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I added some suggestions for the release note.
Co-authored-by: Philip Durbin <[email protected]>
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
approved these changes
Mar 20, 2024
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Looks good. Approved.
I've been running this on my dev3 server and it works fine. The only thing to be aware of is that if the Croissant exporter throws an error, the older format (Schema.org JSON-LD) is shown in the <head> instead. I think this is ok.
scolapasta
approved these changes
Mar 21, 2024
Member
|
Works great! Merging! |
This was referenced May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the new Croissant PR is ready it will replace the content on the header for LD-JSON, this PR will make that the dataset page check for croissants, and if not found it will provide the old LD-JSON, this will preserve current functionality and allow simply drop the croissant Jar on the exporters folder.
Which issue(s) this PR closes:
Partially closes # #10341
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: