Skip to content

Commit 48bad38

Browse files
committed
revert #11301 (manually) due to perf issue #11698
1 parent f3e6581 commit 48bad38

File tree

3 files changed

+2
-19
lines changed

3 files changed

+2
-19
lines changed

src/main/java/edu/harvard/iq/dataverse/DatasetPage.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,6 @@ public enum DisplayMode {
331331
private List<SelectItem> linkingDVSelectItems;
332332
private Dataverse linkingDataverse;
333333
private Dataverse selectedHostDataverse;
334-
private boolean hasDataversesToChoose;
335334

336335
public Dataverse getSelectedHostDataverse() {
337336
return selectedHostDataverse;
@@ -1773,11 +1772,6 @@ public void setDataverseTemplates(List<Template> dataverseTemplates) {
17731772
this.dataverseTemplates = dataverseTemplates;
17741773
}
17751774

1776-
public boolean isHasDataversesToChoose() {
1777-
this.hasDataversesToChoose = dataverseService.findAll().size() > 1;
1778-
return this.hasDataversesToChoose;
1779-
}
1780-
17811775
public Template getDefaultTemplate() {
17821776
return defaultTemplate;
17831777
}

src/main/java/edu/harvard/iq/dataverse/DataverseConverter.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,30 +13,19 @@
1313
import jakarta.faces.convert.Converter;
1414
import jakarta.faces.convert.FacesConverter;
1515

16-
import java.util.logging.Logger;
17-
1816
/**
1917
*
2018
* @author skraffmiller
2119
*/
2220
@FacesConverter("dataverseConverter")
2321
public class DataverseConverter implements Converter {
24-
private static final Logger logger = Logger.getLogger(DatasetPage.class.getCanonicalName());
25-
2622

2723
//@EJB
2824
DataverseServiceBean dataverseService = CDI.current().select(DataverseServiceBean.class).get();
2925

3026
@Override
3127
public Object getAsObject(FacesContext facesContext, UIComponent component, String submittedValue) {
32-
if (submittedValue == null || !submittedValue.matches("[0-9]+")) {
33-
logger.fine("Submitted value is not a host dataverse number but: " + submittedValue);
34-
return CDI.current().select(DatasetPage.class).get().getSelectedHostDataverse();
35-
}
36-
else {
37-
return dataverseService.find(Long.valueOf(submittedValue));
38-
}
39-
//return dataverseService.findByAlias(submittedValue);
28+
return dataverseService.findByAlias(submittedValue);
4029
}
4130

4231
@Override

src/main/webapp/dataset.xhtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -753,7 +753,7 @@
753753
<!-- Create/Edit editMode -->
754754
<ui:fragment rendered="#{DatasetPage.editMode == 'METADATA' or DatasetPage.editMode == 'CREATE'}">
755755
<p:focus context="datasetForm"/>
756-
<div class="form-group" jsf:rendered="#{DatasetPage.hasDataversesToChoose and DatasetPage.editMode == 'CREATE'}">
756+
<div class="form-group">
757757
<label jsf:for="#{DatasetPage.editMode == 'CREATE' ? 'selectHostDataverse_input' : 'select_HostDataverse_Static'}" class="col-md-3 control-label">
758758
#{bundle.hostDataverse}
759759
<span class="glyphicon glyphicon-question-sign tooltip-icon"

0 commit comments

Comments
 (0)