Add more options for the password displaying#587
Merged
annejan merged 3 commits intoIJHack:masterfrom Jan 28, 2023
Merged
Conversation
Author
|
Just to say it: I adapted the way you did it, like but in such a case, it's not really meaningful to use a const reference to a bool value. The pointer to the bool value is bigger than the value itself, so it's actually worse than simply passing the variable by value ;-) But this is another story … |
annejan
approved these changes
Jan 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses both issue #586 and issue #577.
I added two additional checkboxes to the configuration dialog:
QTextBrowserand allQLineEdits used to display password filesQTextBrowser, aspassdoes when used on the console.Imo this won't hurt, as the default behavior remains unchanged, but it's convenient for console pass users that want to have the same behavior in QtPass.