Don't call QtPass::setup() from QtPass class constructor (should fix #466)#482
Merged
annejan merged 2 commits intoIJHack:masterfrom Oct 7, 2019
maciejsszmigiero:qtpass-class-setup-fix
Merged
Don't call QtPass::setup() from QtPass class constructor (should fix #466)#482annejan merged 2 commits intoIJHack:masterfrom maciejsszmigiero:qtpass-class-setup-fix
annejan merged 2 commits intoIJHack:masterfrom
maciejsszmigiero:qtpass-class-setup-fix
Conversation
The QtPass class is not usable without a MainWindow object so it can as well take it directly as its constructor parameter.
QtPass::setup() cannot be called from this class constructor as it possibly calls back MainWindow::config() method. QtPass constructor is in turn called from the MainWindow one so the MainWindow object might not be fully constructed yet. It looks like this was introduced in commit bc19f9e. Rename QtPass::setup() to QtPass::init() and call it explicitly at the end of the MainWindow constructor. Should fix #466, but the whole thing really needs a refactoring to establish a clear QtPass -> MainWindow (or MainWindow -> QtPass) relationship and to make sure there aren't any circular dependencies there (and other similar bugs).
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
======================================
Coverage 7.15% 7.15%
======================================
Files 44 44
Lines 2851 2851
======================================
Hits 204 204
Misses 2647 2647
Continue to review full report at Codecov.
|
This was referenced Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QtPass::setup() cannot be called from this class constructor as it
possibly calls back MainWindow::config() method.
QtPass constructor is in turn called from the MainWindow one so the
MainWindow object might not be fully constructed yet.
It looks like this was introduced in commit bc19f9e.
Rename QtPass::setup() to QtPass::init() and call it explicitly at the end
of the MainWindow constructor.
Should fix #466, but the whole thing
really needs a refactoring to establish a clear QtPass -> MainWindow (or
MainWindow -> QtPass) relationship and to make sure there aren't any
circular dependencies there (and other similar bugs).