Add missing finishedShow() signal connection in PasswordDialog constructor (fixes the "Edit password" function)#473
Merged
annejan merged 1 commit intoIJHack:masterfrom Sep 9, 2019
maciejsszmigiero:passworddialog-finishedshow-fix
Merged
Add missing finishedShow() signal connection in PasswordDialog constructor (fixes the "Edit password" function)#473annejan merged 1 commit intoIJHack:masterfrom maciejsszmigiero:passworddialog-finishedshow-fix
annejan merged 1 commit intoIJHack:masterfrom
maciejsszmigiero:passworddialog-finishedshow-fix
Conversation
…uctor Commit 990b89c ("Removed unused headers from mainwindow.cpp. Disable UseTrayIcon if it's not available for the OS.") moved Pass finishedShow() signal connection for a PasswordDialog from MainWindow::setPassword() to the (first) PasswordDialog constructor. However PasswordDialog has actually two constructors, and the second one needs to make this connection, too, otherwise the "Edit password" function does not load the edited entry data. See: #423 #465 #470
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
=========================================
- Coverage 7.33% 7.32% -0.01%
=========================================
Files 44 44
Lines 2796 2798 +2
=========================================
Hits 205 205
- Misses 2591 2593 +2
Continue to review full report at Codecov.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 990b89c ("Removed unused headers from mainwindow.cpp. Disable UseTrayIcon if it's not available for the OS.")
moved Pass finishedShow() signal connection for a PasswordDialog from
MainWindow::setPassword() to the (first) PasswordDialog constructor.
However PasswordDialog has actually two constructors, and the second one
needs to make this connection, too, otherwise the "Edit password" function
does not load the edited entry data.
See:
#423
#465
#470