Fix missing app ID and icon on Wayland.#468
Merged
annejan merged 1 commit intoIJHack:masterfrom Aug 28, 2019
Merged
Conversation
X11/Wayland needs to know the name of the .desktop file to show a dock icon and application name. X11 has various means of guessing the filename (often WM_NAME). Wayland is a bit more strict, and requires that either the filename match the AppId or the .desktop filename be specified.
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
=========================================
- Coverage 7.41% 7.41% -0.01%
=========================================
Files 44 44
Lines 2765 2766 +1
=========================================
Hits 205 205
- Misses 2560 2561 +1
Continue to review full report at Codecov.
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X11/Wayland needs to know the name of the .desktop file to show a dock
icon and application name. X11 has various means of guessing the
filename (often WM_NAME). Wayland is a bit more strict, and requires
that either the filename match the AppId or the .desktop filename be
specified.
By specifying the .desktop filename QT will set the AppId automatically (from the
Execfield I believe):Tested on a Gnome 3.32 Wayland session. To run using XWayland, set
QT_QPA_PLATFORM=xcb. To run using Wayland setQT_QPA_PLATFORM=wayland.