Merged
Conversation
It causes a huge amount of completely irrelevant warnings on that compiler.
No idea why "or" would work at all, but definitely fails to compile on MSVC.
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=========================================
- Coverage 6.46% 5.87% -0.59%
=========================================
Files 39 39
Lines 2585 2586 +1
=========================================
- Hits 167 152 -15
- Misses 2418 2434 +16
Continue to review full report at Codecov.
|
src/mainwindow.cpp
Outdated
| // For freshStart, proxyModel is not yet configured | ||
| // and maniplating it will assert | ||
| if (!freshStart) | ||
| ui->treeView->setRootIndex(proxyModel.mapFromSource( |
Contributor
There was a problem hiding this comment.
Please indent the line after the if. Otherwise this looks very confusing.
mapFromSource can't be called when the proxyModel has no source model set yet.
rdoeffinger
force-pushed
the
bugfixes
branch
from
04c9ca2 to
68490dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.