pwgen: fix inverted "Generate ... less secure passwords" checkbox#409
Merged
annejan merged 1 commit intoIJHack:masterfrom Aug 6, 2018
Merged
pwgen: fix inverted "Generate ... less secure passwords" checkbox#409annejan merged 1 commit intoIJHack:masterfrom
annejan merged 1 commit intoIJHack:masterfrom
Conversation
Checking the checkbox "Generate easy to memorize but less secure passwords" (aka `isLessRandom()`) means _omitting_ "--secure" option to `pwgen`. Unchecking the checkbox means _passing_ "--secure" option to `pwgen`, which is meant to be the default for QtPass. This got broken in b11e71d Use new executor in Pass Fix this by inverting the check once again.
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
======================================
Coverage 6.46% 6.46%
======================================
Files 39 39
Lines 2585 2585
======================================
Hits 167 167
Misses 2418 2418
Continue to review full report at Codecov.
|
Contributor
Author
|
Thank you for merging this so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking the checkbox "Generate easy to memorize but less secure passwords"
(aka
isLessRandom())means omitting "--secure" option to
pwgen.Unchecking the checkbox means passing "--secure" option to
pwgen,which is meant to be the default for QtPass.
This got broken in
b11e71d Use new executor in Pass
Fix this by inverting the check once again.