Some fixes and refactoring.#376
Merged
annejan merged 5 commits intoIJHack:masterfrom Apr 28, 2018
UnitooTeam:master
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
=========================================
+ Coverage 6.25% 6.48% +0.22%
=========================================
Files 39 39
Lines 2684 2590 -94
Branches 347 341 -6
=========================================
Hits 168 168
+ Misses 2510 2416 -94
Partials 6 6
Continue to review full report at Codecov.
|
1 similar comment
annejan
approved these changes
Apr 28, 2018
Member
|
I really love all the work you are doing here! |
Contributor
Author
|
i like hack with code :) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tryied a big refactoring but first we need to clean up classes from duplicated code or similar code.