Skip to content

Comments

Cleaning #includes#364

Merged
annejan merged 2 commits intoIJHack:masterfrom
UnitooTeam:master
Apr 18, 2018
Merged

Cleaning #includes#364
annejan merged 2 commits intoIJHack:masterfrom
UnitooTeam:master

Conversation

@FiloSpaTeam
Copy link
Contributor

@FiloSpaTeam FiloSpaTeam commented Apr 18, 2018 •
edited
Loading

Goals:

  • Faster compilation
  • Remove unused or recursive headers
  • Now refactor code is simpler

@annejan
Copy link
Member

annejan commented Apr 18, 2018

Checking this out ASAP

@annejan annejan self-requested a review April 18, 2018 14:05
@annejan annejan self-assigned this Apr 18, 2018
@FiloSpaTeam
Copy link
Contributor Author

FiloSpaTeam commented Apr 18, 2018

Don't worry 👍
http://www.bartvermijlen.com/4-reasons-why-you-should-stop-using-the-word-asap/

@codecov
Copy link

codecov bot commented Apr 18, 2018 •
edited
Loading

Codecov Report

Merging #364 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #364      +/-   ##
=========================================
+ Coverage    6.34%   6.35%   +<.01%     
=========================================
  Files          39      39              
  Lines        2710    2707       -3     
  Branches      355     355              
=========================================
  Hits          172     172              
+ Misses       2532    2529       -3     
  Partials        6       6
Impacted Files Coverage Δ
src/trayicon.cpp 0% <ø> (ø) ⬆️
src/passworddialog.cpp 74.66% <ø> (ø) ⬆️
src/mainwindow.h 0% <ø> (ø) ⬆️
src/trayicon.h 0% <ø> (ø) ⬆️
src/qtpasssettings.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <ø> (ø) ⬆️
src/qtpasssettings.cpp 2.81% <ø> (ø) ⬆️
src/storemodel.cpp 0% <ø> (ø) ⬆️
src/usersdialog.h 0% <ø> (ø) ⬆️
src/keygendialog.cpp 0% <ø> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de84470...386faf1. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 18, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 6.269% when pulling 386faf1 on UnitooTeam:master into de84470 on IJHack:master.

annejan
annejan approved these changes Apr 18, 2018
View reviewed changes
Copy link
Member

@annejan annejan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I don't like the commenting out of #includes
Will remove them after merge ;)

@annejan annejan merged commit 39b5ef4 into IJHack:master Apr 18, 2018
@FiloSpaTeam
Copy link
Contributor Author

FiloSpaTeam commented Apr 18, 2018

Oh sorry, i clean up 👍

@annejan
Copy link
Member

annejan commented Apr 18, 2018

No worries, merged, already on it :-)

This is something nice to do in the sun today 🌞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annejan annejan annejan approved these changes

Assignees

@annejan annejan

Labels

enhancement refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FiloSpaTeam @annejan @coveralls