Fix pwgen and refactor Pass::finished#271
Merged
annejan merged 2 commits intoIJHack:masterfrom Jan 9, 2017
Merged
Conversation
annejan
approved these changes
Jan 9, 2017
annejan
approved these changes
Jan 9, 2017
Member
annejan
left a comment
annejan
left a comment
There was a problem hiding this comment.
Way better, and it seems my interpretation of the CI notification might have broken the previous iteration.
Thanks for these fixes!
Contributor
Author
|
On the bright side you made me update it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #262.
Also "revert' fix for break added in switch. It was unreadable, sorry for that. I hope it's better now.