Improving properties metadata#995
Merged
andrewlee94 merged 57 commits intoIDAES:mainfrom Jan 20, 2023
Merged
Conversation
added 18 commits
October 17, 2022 10:17
andrewlee94
added
enhancement
Contributor
Author
|
Note that test failures are expected for now - there are some tests that are using the property metadata for unexpected purposes. |
Codecov ReportBase: 70.06% // Head: 70.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
+ Coverage 70.06% 70.18% +0.11%
==========================================
Files 397 399 +2
Lines 65077 65318 +241
Branches 12058 12089 +31
==========================================
+ Hits 45597 45844 +247
- Misses 17131 17132 +1
+ Partials 2349 2342 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jsiirola
reviewed
Dec 5, 2022
added 15 commits
December 6, 2022 08:30
jsiirola
approved these changes
Jan 17, 2023
| if meth is None: | ||
| super().__setattr__("_method", None) | ||
| else: | ||
| super().__setattr__("_method", str(meth)) |
This was referenced Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #669
Summary/Motivation:
This PR introduces a new PropertyMetadata and PropertySet object for recording what thermophysical properties are supported by a property package. The eventual goal is to have a concrete definition of the standard properties used in IDAES that can be accessed programmatically and does not rely on string constants, as well as formalizing what metadata is stored for each.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: