Running black on the entire repo#894
Merged
lbianchi-lbl merged 4 commits intoIDAES:mainfrom Jun 30, 2022
Merged
Conversation
Member
Author
|
This still needs the GHA hooks to enforce this. |
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
==========================================
- Coverage 69.50% 69.27% -0.24%
==========================================
Files 578 498 -80
Lines 64859 64322 -537
Branches 12064 12038 -26
==========================================
- Hits 45080 44558 -522
+ Misses 17508 17505 -3
+ Partials 2271 2259 -12
Continue to review full report at Codecov.
|
Add CI check to ensure code is Black-formatted
Member
Author
|
This need #897 resolved first. |
lbianchi-lbl
approved these changes
Jun 30, 2022
bpaul4
added a commit
to MAZamarripa/idaes-pse
that referenced
this pull request
Jul 18, 2022
* Sphinx Documentation Build Issue (IDAES#890) * switch lang flag to 'en' * Flag formatting * Update path reference * updating power plant capcost and QGESS tests to run as expected * bring over MEA_CCS updates and tests * running black on costing/ directory * move custom dicts to new file * fix some spacing causing doc build errors * Replace method calls with UnitModelCostingBlocks * Running black on the entire repo (IDAES#894) * Running black on the entire repo * Add pinned requirement for Black stable version * Add CI check to ensure code is Black-formatted Co-authored-by: Ludovico Bianchi <[email protected]> * Fix PySMO tests (IDAES#903) * Minor change to trigger tests * Added abs to tolerance check * Run black * Remove string comparison * Tighten tolerance * Fixed kriging test by removing variable dependence * bring in report method updates * bring in more MEA CCS updates * Add check on total TPC * final formatting fixes * Update report method Adding cost of electricity and cost of capture to report method * Black reformatting * Update report method Fixing units of cost of electricity Co-authored-by: Keith Beattie <[email protected]> Co-authored-by: Ludovico Bianchi <[email protected]> Co-authored-by: OOAmusat <[email protected]> Co-authored-by: Daison2102 <[email protected]>
Closed
andrewlee94
pushed a commit
that referenced
this pull request
Oct 14, 2022
* updating power plant costing to new costing framework * updating power plant capcost and QGESS tests to run as expected * bring over MEA_CCS updates and tests * running black on costing/ directory * move custom dicts to new file * fix some spacing causing doc build errors * Replace method calls with UnitModelCostingBlocks * bring in report method updates * bring in more MEA CCS updates * Add check on total TPC * final formatting fixes * Update report method Adding cost of electricity and cost of capture to report method * Black reformatting * Update report method Fixing units of cost of electricity * Fixing test issues, bringing in MEA_CCS code (#1) * Sphinx Documentation Build Issue (#890) * switch lang flag to 'en' * Flag formatting * Update path reference * updating power plant capcost and QGESS tests to run as expected * bring over MEA_CCS updates and tests * running black on costing/ directory * move custom dicts to new file * fix some spacing causing doc build errors * Replace method calls with UnitModelCostingBlocks * Running black on the entire repo (#894) * Running black on the entire repo * Add pinned requirement for Black stable version * Add CI check to ensure code is Black-formatted Co-authored-by: Ludovico Bianchi <[email protected]> * Fix PySMO tests (#903) * Minor change to trigger tests * Added abs to tolerance check * Run black * Remove string comparison * Tighten tolerance * Fixed kriging test by removing variable dependence * bring in report method updates * bring in more MEA CCS updates * Add check on total TPC * final formatting fixes * Update report method Adding cost of electricity and cost of capture to report method * Black reformatting * Update report method Fixing units of cost of electricity Co-authored-by: Keith Beattie <[email protected]> Co-authored-by: Ludovico Bianchi <[email protected]> Co-authored-by: OOAmusat <[email protected]> Co-authored-by: Daison2102 <[email protected]> * costing updates * costing updates * improving generic variable O&M costs calculation * Updating currency and basis unit handling, other minor fixes * Zipping together costing dictionaries * Improvements from review comments * Updating tests for new changes * Updating author tags * Removing QGESS tests, updating NGCC tests, adding capcost tests, param unit fixes * Sort author list * General improvements and cost variable unit corrections * Removing deprecated default arguments * Addressing most review comments * Addressing more review comments * Testing and coverage improvements * Resolving pylint and directory reference issues * Separating power plant currency units * cleaning up comments * Final fixes from review comments * Add some checks to json regeneration test Co-authored-by: Miguel Zamarripa-Perez <[email protected]> Co-authored-by: Daison2102 <[email protected]> Co-authored-by: Keith Beattie <[email protected]> Co-authored-by: Ludovico Bianchi <[email protected]> Co-authored-by: OOAmusat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
The desire to have a common, enforced coding style.
Summary/Motivation:
This is the result of running
black .at the top of the repoChanges proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: