Add holdup initialization to MSContactor#1707
Merged
dallan-keylogic merged 5 commits intoIDAES:mainfrom Nov 21, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
==========================================
- Coverage 77.44% 77.43% -0.01%
==========================================
Files 395 395
Lines 64792 64810 +18
Branches 10902 10908 +6
==========================================
+ Hits 50178 50187 +9
- Misses 12099 12108 +9
Partials 2515 2515 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dallan-keylogic
requested review from
agarciadiego and
bpaul4
as code owners
Member
|
@dallan-keylogic putting this not on the Nov release but the Feb release. |
MarcusHolly
approved these changes
Nov 21, 2025
| for stream in model.streams: | ||
| holdup_var = getattr(model, stream + "_material_holdup") | ||
| holdup_eqn = getattr(model, stream + "_material_holdup_constraint") | ||
| # calculate_variable_from_constraint(holdup_var, holdup_eqn) |
dallan-keylogic
commented
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This PR adds additional initialization behavior for the MSContactor when
has_holdup=True.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: