Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
- Coverage 77.45% 77.43% -0.03%
==========================================
Files 395 395
Lines 64792 64792
Branches 10902 10902
==========================================
- Hits 50186 50173 -13
- Misses 12095 12105 +10
- Partials 2511 2514 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@dallan-keylogic I think we should be fine to unpin the Pyomo version for IDAES but we should double check which version of Pyomo WaterTAP and Prommis are being tested against. If they start testing against Pyomo 6.9.5, there is a chance they could hit the same pylint failures we saw in IDAES. |
sufikaur
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Now that #1683 has been merged, we should unpin Pyomo. I'd like to require versions greater than 6.9.5 because an issue with the IPOPT solver parser was fixed in that version. (Is there any particular reason we should allow earlier versions?)
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: