Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
==========================================
- Coverage 77.46% 77.44% -0.02%
==========================================
Files 395 395
Lines 64760 64763 +3
Branches 10897 10897
==========================================
- Hits 50168 50158 -10
- Misses 12084 12094 +10
- Partials 2508 2511 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sufikaur
approved these changes
Nov 6, 2025
Contributor
|
Another potential solution could be into using a context manager. However, since this file should go away soon, this solution is good. The way to remove this file is setuptools_scm (see pyproject.toml PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
When trying to run tests in WaterTap that depended on the IDAES
PropertyTestHarness, I encountered a strange error in Pytest:diagnostics_toolbox_scalingwas my local IDAES branch.After doing some troubleshooting, I was able to trace this problem to
ver.py:It appears that we had a minor memory leak from opening files without closing them. I've made some minor modifications to close the files after we're done with them.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: