Heater and Heat Exchanger Scalers#1694
Merged
dallan-keylogic merged 12 commits intoIDAES:scaling_toolboxfrom Oct 31, 2025
Merged
Heater and Heat Exchanger Scalers#1694dallan-keylogic merged 12 commits intoIDAES:scaling_toolboxfrom
dallan-keylogic merged 12 commits intoIDAES:scaling_toolboxfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## scaling_toolbox #1694 +/- ##
================================================
Coverage 77.39% 77.40%
================================================
Files 395 395
Lines 64592 64629 +37
Branches 10851 10859 +8
================================================
+ Hits 49993 50026 +33
Misses 12093 12093
- Partials 2506 2510 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
strahlw
reviewed
Oct 30, 2025
| Tests for 0D heat exchanger models. | ||
|
|
||
| Author: John Eslick | ||
| Authors: John Eslick, Will Stralhl, Douglas Allan |
Contributor
There was a problem hiding this comment.
Minor typo: my last name is "Strahl"
Appreciate the authorship attribution despite the magnitude of the contribution :)
strahlw
reviewed
Oct 30, 2025
| """ | ||
|
|
||
| __author__ = "John Eslick" | ||
| __author__ = "John Eslick, Will Stralhl, Douglas Allan" |
Contributor
There was a problem hiding this comment.
Minor typo: my last name is "Strahl"
MarcusHolly
approved these changes
Oct 30, 2025
strahlw
reviewed
Oct 30, 2025
| ) | ||
|
|
||
| cold_side_h_in[t] = h_in_cold | ||
| hot_side_h_in[t] = h_in_hot |
Contributor
There was a problem hiding this comment.
I think you can remove the storing of the enthalpy flows in the dictionaries - they are not used. (This is an artifact of my attempt)
dallan-keylogic
requested review from
MAZamarripa,
aostace01,
avdudchenko,
ksbeattie,
rundxdi and
sufikaur
as code owners
dallan-keylogic
added a commit
that referenced
this pull request
Nov 6, 2025
* feat: add 0d heat exchanger scaler * HX0D scaling * heater scaler * attribution * pylint * avoid reliance on integration tests * review * minor change to reset diffs * revert minor change --------- Co-authored-by: strahlw <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Adds scaler objects for the heater and heat exchanger models.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: