Scalers objects for the FeedFlash#1692
Merged
dallan-keylogic merged 2 commits intoIDAES:scaling_toolboxfrom Oct 29, 2025
Merged
Scalers objects for the FeedFlash#1692dallan-keylogic merged 2 commits intoIDAES:scaling_toolboxfrom
dallan-keylogic merged 2 commits intoIDAES:scaling_toolboxfrom
Conversation
Daison2102
requested review from
MarcusHolly,
Ryan-Hughes-8 and
dallan-keylogic
Contributor
dallan-keylogic
left a comment
dallan-keylogic
left a comment
There was a problem hiding this comment.
Just one comment, after which it should be ready to merge (so long as CodeCov agrees).
Comment on lines
58
to
59
| NOTE: change this: The only unit model level constraint is a constraint that sets the | ||
| rates of reaction for all rate reactions to zero, which is scaled here. |
Contributor
There was a problem hiding this comment.
It looks like you forgot to change this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scaling_toolbox #1692 +/- ##
===================================================
- Coverage 77.34% 77.33% -0.01%
===================================================
Files 395 395
Lines 64344 64358 +14
Branches 10794 10798 +4
===================================================
+ Hits 49768 49774 +6
- Misses 12077 12081 +4
- Partials 2499 2503 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ryan-Hughes-8
approved these changes
Oct 28, 2025
dallan-keylogic
approved these changes
Oct 29, 2025
dallan-keylogic
merged commit d1de833
into
IDAES:scaling_toolbox
69 of 70 checks passed
dallan-keylogic
pushed a commit
that referenced
this pull request
Nov 6, 2025
* Scalers objects for the FeedFlash * Update feed_flash.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Scalers objects for the
FeedFlashunit model.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: