Skip to content

HX1D and PFR Scalers#1691

Merged
dallan-keylogic merged 3 commits intoIDAES:scaling_toolboxfrom
dallan-keylogic:hx1d_scaler
Oct 30, 2025
Merged

HX1D and PFR Scalers#1691
dallan-keylogic merged 3 commits intoIDAES:scaling_toolboxfrom
dallan-keylogic:hx1d_scaler

Conversation

@dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented Oct 28, 2025

Summary/Motivation:

Scalers objects for the HeatExchanger1D and PlugFlowReactor.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Oct 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (47f5f84) to head (ac0d46f).
⚠️ Report is 9 commits behind head on scaling_toolbox.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           scaling_toolbox    #1691      +/-   ##
===================================================
+ Coverage            77.34%   77.36%   +0.01%     
===================================================
  Files                  395      395              
  Lines                64390    64422      +32     
  Branches             10808    10811       +3     
===================================================
+ Hits                 49805    49837      +32     
  Misses               12081    12081              
  Partials              2504     2504

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dallan-keylogic dallan-keylogic marked this pull request as ready for review October 28, 2025 18:35
MarcusHolly
MarcusHolly approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agarciadiego
agarciadiego approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as that test passes

@dallan-keylogic dallan-keylogic merged commit adeaccf into IDAES:scaling_toolbox Oct 30, 2025
45 checks passed
@dallan-keylogic dallan-keylogic deleted the hx1d_scaler branch October 30, 2025 12:35
dallan-keylogic added a commit that referenced this pull request Nov 6, 2025
@dallan-keylogic
HX1D and PFR Scalers (#1691)
89379dc 
* scalers for the hx1d and pfr

* add xfail back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agarciadiego agarciadiego agarciadiego approved these changes

@MarcusHolly MarcusHolly MarcusHolly approved these changes

@bpaul4 bpaul4 Awaiting requested review from bpaul4 bpaul4 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dallan-keylogic @agarciadiego @MarcusHolly