Scaler for Feed, Product, and StateJunction unit models#1689
Merged
dallan-keylogic merged 19 commits intoIDAES:scaling_toolboxfrom Oct 30, 2025
Merged
Scaler for Feed, Product, and StateJunction unit models#1689dallan-keylogic merged 19 commits intoIDAES:scaling_toolboxfrom
dallan-keylogic merged 19 commits intoIDAES:scaling_toolboxfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scaling_toolbox #1689 +/- ##
================================================
Coverage 77.33% 77.33%
================================================
Files 395 395
Lines 64315 64324 +9
Branches 10781 10781
================================================
+ Hits 49736 49745 +9
Misses 12081 12081
Partials 2498 2498 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcusHolly
reviewed
Oct 28, 2025
Comment on lines
+29
to
+32
| from idaes.models.unit_models.feed import ( | ||
| FeedInitializer as ProductInitializer, | ||
| FeedScaler as ProductScaler, | ||
| ) |
Contributor
There was a problem hiding this comment.
Is there a better name we can give the FeedInitializer and FeedScaler since they'll also be used for products and statejunctions?
Contributor
Author
There was a problem hiding this comment.
Yes---we could call them SingleStateBlockInitializer and SingleStateBlockScaler. I don't want to manage a deprecation cycle for the old name right now, though.
MarcusHolly
approved these changes
Oct 28, 2025
Contributor
MarcusHolly
left a comment
MarcusHolly
left a comment
There was a problem hiding this comment.
One minor comment, but LGTM
agarciadiego
approved these changes
Oct 29, 2025
dallan-keylogic
added a commit
that referenced
this pull request
Nov 6, 2025
* rescue from old branch * change methodology to get reference state * beginning testing * more tests * round out separator scaling testing * extract leach solution properties * ideal separation and inherent reaction tests * flash tests * run black * cull unused imports * test failures and unused code * Fully breaks dependence on ControlVolumeScalerBase * remove defunct scaler * black * Scaler for feed, product, and state junction * respond to Marcus's comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Adds a scaler for the
Feed,Product, andStateJunctionunit models. Because these unit models have no unit-level variables or constraints, the scaler simply calls the property package's scaler.Depends on #1685 .
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: