Separator and Flash Scaler#1685
Merged
dallan-keylogic merged 18 commits intoIDAES:scaling_toolboxfrom Oct 27, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## scaling_toolbox #1685 +/- ##
===================================================
+ Coverage 77.30% 77.33% +0.02%
===================================================
Files 395 395
Lines 64192 64315 +123
Branches 10736 10781 +45
===================================================
+ Hits 49626 49736 +110
- Misses 12073 12081 +8
- Partials 2493 2498 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcusHolly
reviewed
Oct 22, 2025
| None | ||
| """ | ||
| # Fix state variables | ||
| fix_state_vars(self) |
Contributor
There was a problem hiding this comment.
Is this import missing?
Contributor
Author
There was a problem hiding this comment.
Yes, it was.
MarcusHolly
approved these changes
Oct 23, 2025
Ryan-Hughes-8
approved these changes
Oct 23, 2025
Contributor
Ryan-Hughes-8
left a comment
Ryan-Hughes-8
left a comment
There was a problem hiding this comment.
Looks good to me other than the couple spots where it looks like typos are introduced.
| _raise_split_unindexed_fail_err(b.name, l_name) | ||
| else: | ||
| # Unrecognised split type | ||
| # Unrecognised split tupe |
| description="Ideal splitting flag", | ||
| doc="""Argument indicating whether ideal splitting should be used. | ||
| Ideal splitting assumes perfect separation of material, and attempts to | ||
| Ideal splitting assumes perfect spearation of material, and attempts to |
dallan-keylogic
added a commit
that referenced
this pull request
Nov 6, 2025
* rescue from old branch * change methodology to get reference state * beginning testing * more tests * round out separator scaling testing * extract leach solution properties * ideal separation and inherent reaction tests * flash tests * run black * cull unused imports * test failures and unused code * Fully breaks dependence on ControlVolumeScalerBase * remove defunct scaler * black * respond to Marcus's comments * docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Adds scaler objects for the
SeparatorandFlashunit models.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: