New pressure changer and stoichiometric scalers#1678
Merged
dallan-keylogic merged 9 commits intoIDAES:scaling_toolboxfrom Oct 14, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scaling_toolbox #1678 +/- ##
===================================================
+ Coverage 77.11% 77.15% +0.03%
===================================================
Files 395 395
Lines 63727 63765 +38
Branches 10555 10567 +12
===================================================
+ Hits 49145 49195 +50
+ Misses 12079 12077 -2
+ Partials 2503 2493 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dallan-keylogic
requested changes
Oct 6, 2025
Contributor
dallan-keylogic
left a comment
dallan-keylogic
left a comment
There was a problem hiding this comment.
Looks good. Just a handful of comments/changes.
Make sure `overwrite` option is correctly passed
dallan-keylogic
added a commit
that referenced
this pull request
Nov 6, 2025
* adding rstoic and pressure changer scalers and tests * updating pressure changer tests * changing turbine test case * more pressure changer tests * rstoic test cleanup and comment cleanup * remove work_mechanical from pressure changer scaler * added 'propagate_state_scaling' for isentropic properties * added scaling factor tests for rstoic * Apply suggestion from @dallan-keylogic Make sure `overwrite` option is correctly passed --------- Co-authored-by: dallan-keylogic <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Redoing the PR for creating scalers for the pressure changer and stoichiometric reactor unit models.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: