Skip to content

Comments

Add testing 3.13 python to workflow#1669

Merged
sufikaur merged 34 commits intoIDAES:mainfrom
sufikaur:issue-1668
Oct 3, 2025
Merged

Add testing 3.13 python to workflow#1669
sufikaur merged 34 commits intoIDAES:mainfrom
sufikaur:issue-1668

Conversation

@sufikaur
Copy link
Contributor

@sufikaur sufikaur commented Sep 19, 2025 •
edited
Loading

Fixes

Issue 1668

Summary/Motivation:

Catch up to current python releases. 3.14 will be released soon so understanding is supporting 3.13 is possible with the current state.

Changes proposed in this PR:

  • Add 3.13 python to the current workflow

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Notes
current version of greenlet is 3.0.3. thus, the dependency is breaking for 3.13 tests (support added by greenlet for py3.13 with version 3.1.0

@sufikaur sufikaur requested a review from ksbeattie as a code owner September 19, 2025 19:04
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (d495c8d) to head (e52523a).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
- Coverage   77.07%   77.06%   -0.01%     
==========================================
  Files         395      395              
  Lines       62759    62759              
  Branches    10234    10234              
==========================================
- Hits        48369    48366       -3     
- Misses      11978    11982       +4     
+ Partials     2412     2411       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ksbeattie
ksbeattie approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for integration tests

@blnicho blnicho requested a review from mrmundt September 29, 2025 23:06
mrmundt
mrmundt reviewed Sep 30, 2025
View reviewed changes
setup.py Outdated
# FIXME this must be changed to the PyPI distribution for the release
# "idaes-ui",
"idaes-ui @ git+https://github.com/IDAES/idaes-ui@main",
"idaes-ui @ git+https://github.com/sufikaur/idaes-ui@main",
Copy link
Contributor

@mrmundt mrmundt Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be changed back to IDAES.

Copy link
Contributor Author

@sufikaur sufikaur Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is going to be a new idaes ui release and yes this will be changed back

Copy link
Contributor Author

@sufikaur sufikaur Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was approved so integration tests could be tested

Copy link
Member

@blnicho blnicho Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sufikaur you can also add the CI:run-integration label to PRs to force the integration tests to run without needing a reviewer

Copy link
Contributor Author

@sufikaur sufikaur Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I don't think I have permission to add labels. @blnicho @ksbeattie, are either of you able to? I ran integration tests by merging this into my fork.

@sufikaur sufikaur changed the title add testing 3.13 python to workflow Add testing 3.13 python to workflow Oct 1, 2025
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Oct 1, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Oct 1, 2025
@sufikaur sufikaur added the CI:run-integration triggers_workflow: Integration label Oct 1, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Oct 1, 2025
@blnicho
Copy link
Member

blnicho commented Oct 2, 2025

Please add 3.13 as a supported version in the README also: https://github.com/IDAES/idaes-pse/blob/main/README.md?plain=1#L88

We should also check the docs to see if the Python versions we support are explicitly mentioned.

@ksbeattie ksbeattie mentioned this pull request Oct 2, 2025
Closed
@blnicho blnicho linked an issue Oct 2, 2025 that may be closed by this pull request
Add Python support for 3.13 #1668
Closed
blnicho
blnicho reviewed Oct 2, 2025
View reviewed changes
This was referenced Oct 2, 2025
Open
Open
@sufikaur sufikaur merged commit 28990e1 into IDAES:main Oct 3, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrmundt mrmundt mrmundt left review comments

@ksbeattie ksbeattie ksbeattie approved these changes

@blnicho blnicho blnicho approved these changes

@dangunter dangunter Awaiting requested review from dangunter dangunter is a code owner

@bpaul4 bpaul4 Awaiting requested review from bpaul4 bpaul4 is a code owner

Assignees

@sufikaur sufikaur

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Python support for 3.13

5 participants

@sufikaur @blnicho @ksbeattie @mrmundt @idaes-build