Skip to content

Comments

Additional SOC Updates#1667

Merged
dallan-keylogic merged 14 commits intoIDAES:mainfrom
dallan-keylogic:soc_final_changes
Oct 30, 2025
Merged

Additional SOC Updates#1667
dallan-keylogic merged 14 commits intoIDAES:mainfrom
dallan-keylogic:soc_final_changes

Conversation

@dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented Sep 19, 2025

Summary/Motivation:

  • Adds the option to create heat loss terms on the SOC in order to realistically model a hot idle state.
  • Adds a term to modify the exchange current densities at the triple phase boundary to use as a hook for degradation modeling
  • Adds a method to the CrossFlowHeatExchanger1D to enable use of Lagrange-Legendre collocation without structural singularity. (The methods here should be ported to PyomoDAE eventually, see 1D Heat Exchanger needs Upwinding #1581)

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.58333% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.10%. Comparing base (7ec0e54) to head (a2c9940).
⚠️ Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
..._models/soc_submodels/solid_oxide_module_simple.py 75.00% 6 Missing and 2 partials ⚠️
idaes/core/base/control_volume1d.py 66.66% 2 Missing and 1 partial ⚠️
idaes/models/unit_models/heat_exchanger_1D.py 80.00% 1 Missing and 1 partial ⚠️
...tion/unit_models/soc_submodels/solid_oxide_cell.py 96.22% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
+ Coverage   77.08%   77.10%   +0.01%     
==========================================
  Files         395      395              
  Lines       62786    62909     +123     
  Branches    10231    10274      +43     
==========================================
+ Hits        48398    48503     +105     
- Misses      11979    11993      +14     
- Partials     2409     2413       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dallan-keylogic dallan-keylogic added the CI:run-integration triggers_workflow: Integration label Sep 19, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Sep 19, 2025
@dallan-keylogic dallan-keylogic mentioned this pull request Sep 22, 2025
Merged
@dallan-keylogic
Copy link
Contributor Author

dallan-keylogic commented Sep 22, 2025 •
edited
Loading

These failing tests are expected and are fixed in IDAES/examples#150 (which will be merged after this PR is merged into IDAES).

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Sep 25, 2025
NishantGiridhar
NishantGiridhar approved these changes Oct 27, 2025
View reviewed changes
Copy link

@NishantGiridhar NishantGiridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

Ryan-Hughes-8
Ryan-Hughes-8 approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@Ryan-Hughes-8 Ryan-Hughes-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dallan-keylogic dallan-keylogic merged commit e4e51fe into IDAES:main Oct 30, 2025
69 of 70 checks passed
@dallan-keylogic dallan-keylogic deleted the soc_final_changes branch October 30, 2025 23:17
sufikaur pushed a commit to sufikaur/idaes-pse that referenced this pull request Nov 17, 2025
@dallan-keylogic
Additional SOC Updates (IDAES#1667)
90160f9 
* rescue files from branch

* clean up code

* cross flow heat exchanger tests and formatting

* Add tests for solid oxide cell and TPB

* solve test with heat loss terms

* run Black

* pylint

* fix model check and add additonal tests

* get rid of warning when using LL collocation

* Jinliang's changes

* pylint
@dallan-keylogic dallan-keylogic mentioned this pull request Nov 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ryan-Hughes-8 Ryan-Hughes-8 Ryan-Hughes-8 approved these changes

@NishantGiridhar NishantGiridhar NishantGiridhar approved these changes

@bpaul4 bpaul4 Awaiting requested review from bpaul4 bpaul4 is a code owner

@MAZamarripa MAZamarripa Awaiting requested review from MAZamarripa MAZamarripa is a code owner

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@jinliangma jinliangma Awaiting requested review from jinliangma

Assignees

No one assigned

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dallan-keylogic @Ryan-Hughes-8 @NishantGiridhar @ksbeattie @idaes-build