Skip to content

Comments

Off boarding lbianchi-lbl from code ownership#1661

Merged
dallan-keylogic merged 1 commit intoIDAES:mainfrom
sufikaur:issue-1660
Sep 12, 2025
Merged

Off boarding lbianchi-lbl from code ownership#1661
dallan-keylogic merged 1 commit intoIDAES:mainfrom
sufikaur:issue-1660

Conversation

@sufikaur
Copy link
Contributor

@sufikaur sufikaur commented Sep 11, 2025 •
edited
Loading

Fixes

Issue 1660

Summary/Motivation:

Remove ludovico's required approval of certain PRs/ as code owner.

Changes proposed in this PR:

  • Remove or replace lbnianchi-lbl from code ownership document

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@sufikaur sufikaur changed the title Off boarding lbianchi_lbl from code ownership Off boarding lbianchi-lbl from code ownership Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.95%. Comparing base (76b58d6) to head (780b0c6).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1661      +/-   ##
==========================================
- Coverage   77.01%   76.95%   -0.07%     
==========================================
  Files         397      397              
  Lines       63580    63580              
  Branches    10367    10367              
==========================================
- Hits        48968    48926      -42     
- Misses      12170    12217      +47     
+ Partials     2442     2437       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Sep 11, 2025
dallan-keylogic
dallan-keylogic approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adowling2
Copy link
Contributor

adowling2 commented Sep 11, 2025

😢, 😭, and good luck with your next project @lbianchi-lbl

@dallan-keylogic dallan-keylogic merged commit d96090c into IDAES:main Sep 12, 2025
48 checks passed
@dallan-keylogic dallan-keylogic mentioned this pull request Sep 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agarciadiego agarciadiego agarciadiego approved these changes

@dallan-keylogic dallan-keylogic dallan-keylogic approved these changes

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl

@ksbeattie ksbeattie Awaiting requested review from ksbeattie ksbeattie is a code owner

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sufikaur @adowling2 @agarciadiego @dallan-keylogic @ksbeattie