external functions with string arguments#1654
Merged
dallan-keylogic merged 1 commit intoIDAES:scaling_toolboxfrom Sep 23, 2025
Merged
external functions with string arguments#1654dallan-keylogic merged 1 commit intoIDAES:scaling_toolboxfrom
dallan-keylogic merged 1 commit intoIDAES:scaling_toolboxfrom
Conversation
dallan-keylogic
requested review from
agarciadiego and
lbianchi-lbl
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scaling_toolbox #1654 +/- ##
==================================================
Coverage ? 77.03%
==================================================
Files ? 395
Lines ? 63961
Branches ? 10503
==================================================
Hits ? 49273
Misses ? 12211
Partials ? 2477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agarciadiego
approved these changes
Sep 23, 2025
Ryan-Hughes-8
approved these changes
Sep 23, 2025
Contributor
Ryan-Hughes-8
left a comment
Ryan-Hughes-8
left a comment
There was a problem hiding this comment.
Tested this branch locally using iapws95 without any issue.
dallan-keylogic
merged commit 29f1e5c
into
IDAES:scaling_toolbox
40 of 60 checks passed
dallan-keylogic
added a commit
that referenced
this pull request
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Fixes error with
NominalValueExpressionWalkerfor external functions with string arguments.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: