Fix typo of _enthalpy_density_term#1638
Merged
ksbeattie merged 5 commits intoIDAES:mainfrom Aug 28, 2025
Merged
Conversation
fixed to _energy_density_term fixes IDAES#1586
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
=======================================
Coverage 77.01% 77.01%
=======================================
Files 397 397
Lines 63580 63580
Branches 10367 10367
=======================================
Hits 48965 48965
- Misses 12173 12174 +1
+ Partials 2442 2441 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adam-a-a
approved these changes
Jul 23, 2025
agarciadiego
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
This fixes issue #1586
This fixes the typo in idaes-pse/idaes/models/properties/modular_properties/base/generic_property.py as described in issue #1586.
Note there was already a related pull request #1588, but that did not correctly fix the issue (did not have underscore on energy_density_term). I have successfully tested this fix through use of the generic property package.
Summary/Motivation:
This throws an error when calculating scaling factors with a generic property package
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: