Skip to content

Comments

Two quick fixes: units on PH and TS diagrams, documentation for macOS#1589

Merged
ksbeattie merged 6 commits intoIDAES:mainfrom
adowling2:quick-fix
Mar 13, 2025
Merged

Two quick fixes: units on PH and TS diagrams, documentation for macOS#1589
ksbeattie merged 6 commits intoIDAES:mainfrom
adowling2:quick-fix

Conversation

@adowling2
Copy link
Contributor

@adowling2 adowling2 commented Mar 8, 2025

Fixes

Summary/Motivation:

  • The units on the labels for PH and TS diagrams did not update when changing the amount basis
  • The documentation was outdated regarding the availability of macOS binaries

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.85%. Comparing base (6cea367) to head (675e54b).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...roperties/general_helmholtz/helmholtz_functions.py 20.00% 4 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   76.86%   76.85%   -0.02%     
==========================================
  Files         394      394              
  Lines       63233    63241       +8     
  Branches    10355    10359       +4     
==========================================
- Hits        48604    48601       -3     
- Misses      12184    12192       +8     
- Partials     2445     2448       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bpaul4
bpaul4 reviewed Mar 10, 2025
View reviewed changes
dallan-keylogic
dallan-keylogic approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, so long as the change Brandon suggested is accepted.

@adowling2 adowling2 requested a review from bpaul4 March 10, 2025 15:37
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 13, 2025
@ksbeattie ksbeattie merged commit f96196a into IDAES:main Mar 13, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpaul4 bpaul4 bpaul4 approved these changes

@dallan-keylogic dallan-keylogic dallan-keylogic approved these changes

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego is a code owner

@dangunter dangunter Awaiting requested review from dangunter dangunter is a code owner

Assignees

No one assigned

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adowling2 @codecov-commenter @bpaul4 @dallan-keylogic @ksbeattie