fix typo#1588
Closed
ujjawalTHEBATMAN wants to merge 1 commit intoIDAES:mainfrom
ujjawalTHEBATMAN:patch-1
Closed
Conversation
ujjawalTHEBATMAN
requested review from
agarciadiego and
dallan-keylogic
as code owners
Comment on lines
2243
to
+2244
| if self.is_property_constructed("_energy_density_term"): | ||
| for k, v in self._enthalpy_flow_term.items(): | ||
| for k, v in self.energy_density_term.items(): |
Contributor
There was a problem hiding this comment.
Since it's looking for _energy_density_term and not energy_density_term (without the underscore), it's probably better to iterate over that version. I don't know the difference off the top of my head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixed a typo in the code:
Changed _enthalpy_flow_term → self.energy_density_term
Summary/Motivation
This PR corrects a minor typo in the variable name to maintain consistency and avoid potential errors in calculations.
Changes proposed in this PR:
Renamed _enthalpy_flow_term to self.energy_density_term
Ensured all related references are updated accordingly
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions:
My contributions are submitted under the license terms mentioned in the LICENSE.txt file at the top level of this directory.
I confirm that I have the right to make these contributions and grant the necessary license. If my employer holds any intellectual property rights related to these contributions, I confirm that I have obtained the required permission to make these changes on their behalf.