Add Clustering Method to PriceTaker#1579
Merged
adam-a-a merged 28 commits intoIDAES:mainfrom Jul 3, 2025
Merged
Conversation
adam-a-a
reviewed
Feb 25, 2025
adam-a-a
reviewed
Feb 25, 2025
adam-a-a
reviewed
Feb 25, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
==========================================
- Coverage 77.05% 77.00% -0.06%
==========================================
Files 395 395
Lines 63512 63555 +43
Branches 10358 10365 +7
==========================================
- Hits 48942 48941 -1
- Misses 12130 12175 +45
+ Partials 2440 2439 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcusHolly
requested review from
adowling2,
bpaul4,
dangunter and
jsiirola
as code owners
bpaul4
reviewed
Mar 20, 2025
idaes/apps/grid_integration/pricetaker/tests/test_clustering.py
Outdated
Show resolved
Hide resolved
bpaul4
approved these changes
Mar 20, 2025
radhakrishnatg
requested changes
Apr 10, 2025
Contributor
radhakrishnatg
left a comment
radhakrishnatg
left a comment
There was a problem hiding this comment.
I have a few changes. Please see my comments below.
idaes/apps/grid_integration/pricetaker/tests/test_clustering.py
Outdated
Show resolved
Hide resolved
radhakrishnatg
requested changes
Jun 18, 2025
radhakrishnatg
approved these changes
Jul 2, 2025
Contributor
radhakrishnatg
left a comment
radhakrishnatg
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you, @MarcusHolly, for making all the requested changes!
Contributor
|
Merging this and bypassing codecov/patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Adds a literature-based method to the pricetaker model for determining the optimal number of clusters that a dataset should be broken into
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: