Temporarily exclude sphinx 8.2.0 to fix doctests#1572
Merged
lbianchi-lbl merged 4 commits intoIDAES:mainfrom Feb 20, 2025
Merged
Temporarily exclude sphinx 8.2.0 to fix doctests#1572lbianchi-lbl merged 4 commits intoIDAES:mainfrom
lbianchi-lbl merged 4 commits intoIDAES:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1572 +/- ##
==========================================
- Coverage 76.86% 76.86% -0.01%
==========================================
Files 394 394
Lines 63233 63233
Branches 10355 10355
==========================================
- Hits 48604 48601 -3
- Misses 12184 12188 +4
+ Partials 2445 2444 -1 ☔ View full report in Codecov by Sentry. |
adam-a-a
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Doctests started failing with the latest Sphinx release. We noticed similar issues in Pyomo that could be traced to Sphinx extensions that don't yet support Sphinx 8.2.0. This PR excludes this version of Sphinx for now to get IDAES tests passing again. I haven't identified which Sphinx extension is the underlying cause of the issue.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: