Codecov Report

Attention: Patch coverage is 87.50000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (c84a7fe) to head (21979e2).

@@            Coverage Diff             @@
##             main    #1566      +/-   ##
==========================================
+ Coverage   77.01%   77.02%   +0.01%     
==========================================
  Files         395      396       +1     
  Lines       63555    63683     +128     
  Branches    10365    10390      +25     
==========================================
+ Hits        48944    49053     +109     
- Misses      12171    12185      +14     
- Partials     2440     2445       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pylint is complaining about "Possible unbalanced tuple unpacking". The source of the issue is that the function returns three variables, U, svals, and V, if m=n but it additionally returns a basis for the (left) null space if m!=n. There are multiple ways to make this warning go away, but I want some feedback about the return signature of the function. Should I always return the null space, or only if a specific option is included?

Pylint is complaining about "Possible unbalanced tuple unpacking". The source of the issue is that the function returns three variables, U, svals, and V, if m=n but it additionally returns a basis for the (left) null space if m!=n. There are multiple ways to make this warning go away, but I want some feedback about the return signature of the function. Should I always return the null space, or only if a specific option is included?

My recommendation is to always return the same number of items from the function. We've been burned in the past with APIs that return different numbers of things based on arguments/options passed to the function.

Blocked on funding