updated importlib.resources to stop using deprecated path function#1550
Merged
lbianchi-lbl merged 12 commits intoIDAES:mainfrom Feb 14, 2025
Merged
updated importlib.resources to stop using deprecated path function#1550lbianchi-lbl merged 12 commits intoIDAES:mainfrom
lbianchi-lbl merged 12 commits intoIDAES:mainfrom
Conversation
… instead of *path*
… to lines being too long with the new as_file(files(... paradigm needed
…ccessing functions from that
lbianchi-lbl
requested changes
Jan 29, 2025
Contributor
lbianchi-lbl
left a comment
lbianchi-lbl
left a comment
There was a problem hiding this comment.
This is ready to go pending these minor fixes
lbianchi-lbl
requested review from
adowling2,
jsiirola and
ksbeattie
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
- Coverage 76.85% 76.85% -0.01%
==========================================
Files 394 394
Lines 63233 63233
Branches 10355 10355
==========================================
- Hits 48598 48595 -3
- Misses 12190 12194 +4
+ Partials 2445 2444 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lbianchi-lbl
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
This resolves issue #1542
Summary/Motivation:
importlib.resources.pathis deprecated and importlib.resources.files is the remedy for all python version applicable in IDAES (3.9+)Changes proposed in this PR:
updated importlib.resrouces functionality to now use "files" function instead of "path"
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: