Skip to content

Comments

List binary platforms and architectures#1546

Merged
ksbeattie merged 18 commits intoIDAES:mainfrom
dangunter:extensions_list_oses
Dec 19, 2024
Merged

List binary platforms and architectures#1546
ksbeattie merged 18 commits intoIDAES:mainfrom
dangunter:extensions_list_oses

Conversation

@dangunter
Copy link
Member

@dangunter dangunter commented Dec 2, 2024

Fixes

Summary/Motivation:

Add a command to provide some hopefully helpful output about available binary releases for IDAES 'extensions'.
The goal is to help people understand why get-extensions doesn't work for their platform. It probably won't be used by people if get-extensions does work without a hitch.

Changes proposed in this PR:

  • Add idaes get-extensions --info to print the information (and do nothing else)
  • Mention this option if idaes get-extensions itself fails

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dangunter dangunter requested a review from bpaul4 as a code owner December 2, 2024 17:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 15.09434% with 45 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (327d8f3) to head (158374c).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
idaes/commands/extensions.py 15.09% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
- Coverage   77.06%   77.02%   -0.05%     
==========================================
  Files         387      387              
  Lines       62486    62529      +43     
  Branches    10236    10241       +5     
==========================================
+ Hits        48156    48161       +5     
- Misses      11896    11935      +39     
+ Partials     2434     2433       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that this works as intended.

@lbianchi-lbl lbianchi-lbl added enhancement New feature or request Priority:Normal Normal Priority Issue or PR idaes-ext labels Dec 5, 2024
@ksbeattie ksbeattie requested a review from mrmundt December 12, 2024 19:30
Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, it's beautiful and helpful.

@ksbeattie ksbeattie merged commit f92c750 into IDAES:main Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request idaes-ext Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants