changed macosx tutorial to properly handle different mac arch possibi…#1544
Merged
ksbeattie merged 7 commits intoIDAES:mainfrom Feb 13, 2025
Merged
changed macosx tutorial to properly handle different mac arch possibi…#1544ksbeattie merged 7 commits intoIDAES:mainfrom
ksbeattie merged 7 commits intoIDAES:mainfrom
Conversation
…lities with single command
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 77.06% 77.05% -0.01%
==========================================
Files 389 389
Lines 62680 62680
Branches 10276 10276
==========================================
- Hits 48303 48300 -3
- Misses 11939 11943 +4
+ Partials 2438 2437 -1 ☔ View full report in Codecov by Sentry. |
lbianchi-lbl
added
documentation
Member
|
The rendering of this:
I think could be improved. Maybe something more like the following section:
using the |
4 tasks
Member
|
@azaidi06 will look at this today. |
Improve rendering with code-block
Member
|
It's getting better..
but still not quite there. |
Added newline before the code-block directive to rectify rendering issue
removed extraneous backtick in the changed command to help with rendering
adding newline after code-block directive to render correctly
Contributor
Author
|
corrected the newlines missing around the directive and now its rendering correctly 
|
lbianchi-lbl
approved these changes
Feb 12, 2025
lbianchi-lbl
requested changes
Feb 13, 2025
Contributor
lbianchi-lbl
left a comment
lbianchi-lbl
left a comment
There was a problem hiding this comment.
Minor changes (should be enough to hit "Commit suggestion")
remove numbering and re-add double quotes around second command Co-authored-by: Ludovico Bianchi <[email protected]>
lbianchi-lbl
approved these changes
Feb 13, 2025
ksbeattie
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lities with single command
Fixes
This fixes issue #1497 : #1497
Summary/Motivation:
New Mac devices now come with apple silicon which requires a different set of binaries relative to previous intel version -- in order to accommodate both types, a single command is used to determine and download what's appropriate.
Changes proposed in this PR:
Simply changing the tutorial for Macs to accommodate the potential differences in CPU arch -- the command will be able to determine which arch is being used on the device and download the appropriate binaries. This will help mitigate potential mistakes of downloading the incorrect type/version for apple silicon vs intel.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: