updated all mentions/use of anaconda/miniconda to reflect usage of mi…#1513
Merged
lbianchi-lbl merged 11 commits intoIDAES:mainfrom Nov 22, 2024
Merged
updated all mentions/use of anaconda/miniconda to reflect usage of mi…#1513lbianchi-lbl merged 11 commits intoIDAES:mainfrom
lbianchi-lbl merged 11 commits intoIDAES:mainfrom
Conversation
azaidi06
requested review from
bpaul4,
dangunter,
ksbeattie and
lbianchi-lbl
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
- Coverage 77.05% 77.04% -0.01%
==========================================
Files 384 384
Lines 62338 62338
Branches 10222 10222
==========================================
- Hits 48034 48031 -3
- Misses 11875 11879 +4
+ Partials 2429 2428 -1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Do we want apple silicon to be the default cpu to be checking in the Sphinx doc build check? Or intel? This can be found on line 37 in docs/tutorials/getting_started/mac_osx.rst |
lbianchi-lbl
requested changes
Nov 12, 2024
Contributor
lbianchi-lbl
left a comment
lbianchi-lbl
left a comment
There was a problem hiding this comment.
A couple of minor things, but other than that this should be ready to merge.
ksbeattie
reviewed
Nov 15, 2024
ksbeattie
reviewed
Nov 15, 2024
corrected hyperlink in miniforge reference for sphinx docs
corrected hyperlink in miniforge reference for sphinx docs
Contributor
|
I'm pretty sure the links that @ksbeattie pointed out are working now. I'm merging this in because I need these changes for fixing #1540. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
This resolves this issue: #1432
Summary/Motivation:
Idaes is no longer using miniconda and the codebase/documentation does not reflect the switch to Miniforge -- this PR updates everything to reflect the switch to Miniforge and removes references to Anaconda/Miniconda. Tried as best as possible to keep the wording closely aligned to what was represented before.
Changes proposed in this PR:
** There remains mentions of anaconda/miniconda in the docker/jenkinsfiles which I will remove in another PR -- the issue can be seen here: #1511
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: