Fix issue with enthalpy based states trying to use EoS before construciton#1505
Merged
andrewlee94 merged 1 commit intoIDAES:mainfrom Oct 18, 2024
Merged
Fix issue with enthalpy based states trying to use EoS before construciton#1505andrewlee94 merged 1 commit intoIDAES:mainfrom
andrewlee94 merged 1 commit intoIDAES:mainfrom
Conversation
andrewlee94
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1505 +/- ##
==========================================
- Coverage 76.98% 76.98% -0.01%
==========================================
Files 382 382
Lines 61913 61911 -2
Branches 10130 10126 -4
==========================================
- Hits 47665 47660 -5
- Misses 11848 11852 +4
+ Partials 2400 2399 -1 ☔ View full report in Codecov by Sentry. |
dallan-keylogic
approved these changes
Oct 18, 2024
Comment on lines
-140
to
+141
| @pytest.fixture(scope="class") | ||
| @pytest.fixture() |
Contributor
There was a problem hiding this comment.
Just out of curiosity, why are we removing these scopes?
Contributor
Author
There was a problem hiding this comment.
They resulted in tests polluting other tests which resulted in unexpected failures (mainly the first check for defined state effect had flow on effects to other tests)
bpaul4
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1483
Summary/Motivation:
Issue #1483 identified that enthalpy-based state definitions in the modular property framework triggered calls to components constructed by the equation of state module before these had been instantiated. This PR defers the construction of the constraint relating total molar enthalpy to the phase molar enthalpies until after the EoS components have been instantiated.
Changes proposed in this PR:
enth_mol_eqnin enthalpy based state definitions.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: