Address minor issues identified in 10/24 Code Audit#1504
Merged
andrewlee94 merged 8 commits intoIDAES:mainfrom Oct 28, 2024
Merged
Address minor issues identified in 10/24 Code Audit#1504andrewlee94 merged 8 commits intoIDAES:mainfrom
andrewlee94 merged 8 commits intoIDAES:mainfrom
Conversation
andrewlee94
requested review from
agarciadiego,
aostace01,
ksbeattie and
lbianchi-lbl
as code owners
andrewlee94
added
Priority:Normal
agarciadiego
approved these changes
Oct 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1504 +/- ##
==========================================
- Coverage 76.99% 76.98% -0.01%
==========================================
Files 382 382
Lines 61992 61992
Branches 10146 10146
==========================================
- Hits 47730 47727 -3
- Misses 11854 11858 +4
+ Partials 2408 2407 -1 ☔ View full report in Codecov by Sentry. |
andrewlee94
commented
Oct 24, 2024
idaes/models_extra/column_models/tests/test_plate_heat_exchanger.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes None
Summary/Motivation:
The developer team did a code audit in October and identified a number of issues that should be investigated and resolved if possible. This PR addresses those issues that are easily fixed.
Changes proposed in this PR:
xfailmarker on plate heat exchanger tests to onlyxfailon Windows system.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: