Fixing scaling bug related to external functions with string arguments#1487
Merged
andrewlee94 merged 2 commits intoIDAES:mainfrom Sep 10, 2024
Merged
Fixing scaling bug related to external functions with string arguments#1487andrewlee94 merged 2 commits intoIDAES:mainfrom
andrewlee94 merged 2 commits intoIDAES:mainfrom
Conversation
andrewlee94
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
- Coverage 76.84% 76.84% -0.01%
==========================================
Files 376 376
Lines 61087 61091 +4
Branches 13504 13505 +1
==========================================
+ Hits 46942 46945 +3
- Misses 11763 11766 +3
+ Partials 2382 2380 -2 ☔ View full report in Codecov by Sentry. |
bpaul4
approved these changes
Sep 10, 2024
mrmundt
approved these changes
Sep 10, 2024
lbianchi-lbl
pushed a commit
that referenced
this pull request
Oct 1, 2024
(cherry picked from commit b6be02e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1355
Summary/Motivation:
The discussion in #1355 brought up an edge case where the nominal expression walker was failing due to encountering an external function with a string argument.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: