Skip to content

Comments

Pin typos version to latest currently available tag v1.24.5#1486

Merged
lbianchi-lbl merged 3 commits intoIDAES:mainfrom
lbianchi-lbl:pin-typos-version
Sep 5, 2024
Merged

Pin typos version to latest currently available tag v1.24.5#1486
lbianchi-lbl merged 3 commits intoIDAES:mainfrom
lbianchi-lbl:pin-typos-version

Conversation

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Sep 5, 2024

Resolves #1485

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Sep 5, 2024
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review September 5, 2024 18:36
@lbianchi-lbl lbianchi-lbl requested a review from bpaul4 September 5, 2024 18:40
@lbianchi-lbl
Copy link
Contributor Author

lbianchi-lbl commented Sep 5, 2024

@bpaul4 I've added you and myself as code owners for the typos config file, so that we're added as reviewers whenever it's modified.

bpaul4
bpaul4 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@bpaul4 bpaul4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @lbianchi-lbl for opening the PR. Noting that we will probably reverse the "workpace" exception once #1484 is merged, or as part of it if this PR is merged first.

@lbianchi-lbl
Copy link
Contributor Author

lbianchi-lbl commented Sep 5, 2024

This is great, thank you @lbianchi-lbl for opening the PR. Noting that we will probably reverse the "workpace" exception once #1484 is merged.

Yeah, I was planning on removing the DMF exceptions directly within #1484 as a further double-check that all affected files have been removed.

@lbianchi-lbl lbianchi-lbl merged commit 8140a3d into IDAES:main Sep 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (fe422c0) to head (645e249).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
- Coverage   76.37%   76.36%   -0.01%     
==========================================
  Files         393      393              
  Lines       65086    65086              
  Branches    14426    14426              
==========================================
- Hits        49708    49705       -3     
- Misses      12816    12820       +4     
+ Partials     2562     2561       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpaul4 bpaul4 bpaul4 approved these changes

@andrewlee94 andrewlee94 Awaiting requested review from andrewlee94

@dallan-keylogic dallan-keylogic Awaiting requested review from dallan-keylogic dallan-keylogic is a code owner

@ksbeattie ksbeattie Awaiting requested review from ksbeattie ksbeattie is a code owner

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pin version used for CI spellchecking to avoid surprise failures after updates

3 participants

@lbianchi-lbl @codecov-commenter @bpaul4