Remove idaes.core.dmf and related code#1484
Merged
lbianchi-lbl merged 21 commits intoIDAES:mainfrom Sep 6, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
+ Coverage 76.37% 76.83% +0.46%
==========================================
Files 393 376 -17
Lines 65086 61087 -3999
Branches 14426 13504 -922
==========================================
- Hits 49708 46939 -2769
+ Misses 12816 11767 -1049
+ Partials 2562 2381 -181 ☔ View full report in Codecov by Sentry. |
bpaul4
approved these changes
Sep 5, 2024
Contributor
bpaul4
left a comment
There was a problem hiding this comment.
The exceptions, deletions, and changes look good to me.
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1368
Changes proposed in this PR:
idaes/core/dmfidaes/core/dmf/__init__.pyto add deprecation to be shown when importingidaes.core.dmfsetup.pydmf_datadirectoryTo review
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: