add UI return, then visualize() can return now#1466
Merged
dangunter merged 6 commits intoIDAES:mainfrom Aug 28, 2024
Merged
Conversation
… save_diagram etc.
…I code, this way has no need to up date PSE when want to update return items in UI
CopyDemon
requested review from
andrewlee94,
dallan-keylogic and
lbianchi-lbl
as code owners
CopyDemon
requested review from
dangunter
and removed request for
andrewlee94 and
dallan-keylogic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
- Coverage 76.37% 76.36% -0.01%
==========================================
Files 393 393
Lines 65085 65086 +1
Branches 14426 14426
==========================================
- Hits 49708 49705 -3
- Misses 12815 12820 +5
+ Partials 2562 2561 -1 ☔ View full report in Codecov by Sentry. |
lbianchi-lbl
requested changes
Aug 13, 2024
Contributor
lbianchi-lbl
left a comment
lbianchi-lbl
left a comment
There was a problem hiding this comment.
Looks good apart from these minor changes.
update return to snake_case Co-authored-by: Ludovico Bianchi <[email protected]>
…his module Co-authored-by: Ludovico Bianchi <[email protected]>
Contributor
|
This is how this looks in the Sphinx docs:
|
lbianchi-lbl
requested changes
Aug 15, 2024
Contributor
lbianchi-lbl
left a comment
lbianchi-lbl
left a comment
There was a problem hiding this comment.
One more minor issue with the Sphinx rendering.
…lt:` prefix. This prevents Sphinx from incorrectly adding an extra "Return type" field in the documentation. Co-authored-by: Ludovico Bianchi <[email protected]>
lbianchi-lbl
approved these changes
Aug 24, 2024
dangunter
approved these changes
Aug 27, 2024
Member
dangunter
left a comment
dangunter
left a comment
There was a problem hiding this comment.
Looks good, but a test would be nice. Will add another issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Add return to UI.visualize() then user can use visualize() returned value and functions
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: