Skip to content

Comments

Minor Power Plant Costing Fixes#1418

Merged
lbianchi-lbl merged 7 commits intoIDAES:mainfrom
bpaul4:minor-ppcosting-fixes
Jul 19, 2024
Merged

Minor Power Plant Costing Fixes#1418
lbianchi-lbl merged 7 commits intoIDAES:mainfrom
bpaul4:minor-ppcosting-fixes

Conversation

@bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented May 28, 2024

Fixes

Minor modifications to power plant costing.

Changes proposed in this PR:

  • correct units on a couple of terms
  • set additional_cost_of_electricity to initialize at 0, add details to docstring
  • fix transport_cost units and handling

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bpaul4 bpaul4 requested a review from anujad95 May 28, 2024 15:49
@bpaul4 bpaul4 self-assigned this May 28, 2024
@bpaul4 bpaul4 added the Priority:High High Priority Issue or PR label May 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.35%. Comparing base (85bf669) to head (1f828e4).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...ra/power_generation/costing/power_plant_capcost.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   76.36%   76.35%   -0.01%     
==========================================
  Files         394      394              
  Lines       64953    64953              
  Branches    14404    14404              
==========================================
- Hits        49601    49598       -3     
- Misses      12793    12797       +4     
+ Partials     2559     2558       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AlexNoring
AlexNoring approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@AlexNoring AlexNoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dallan-keylogic
dallan-keylogic approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie enabled auto-merge (squash) July 18, 2024 23:41
@lbianchi-lbl lbianchi-lbl disabled auto-merge July 19, 2024 13:18
@lbianchi-lbl lbianchi-lbl merged commit 4d56ce2 into IDAES:main Jul 19, 2024
@bpaul4 bpaul4 deleted the minor-ppcosting-fixes branch January 6, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexNoring AlexNoring AlexNoring approved these changes

@anujad95 anujad95 anujad95 approved these changes

@dallan-keylogic dallan-keylogic dallan-keylogic approved these changes

@MAZamarripa MAZamarripa Awaiting requested review from MAZamarripa MAZamarripa is a code owner

Assignees

@bpaul4 bpaul4

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bpaul4 @codecov-commenter @AlexNoring @anujad95 @dallan-keylogic @lbianchi-lbl @ksbeattie